feat(typography): add PRETTY and BALANCE textWrap modes#8312
Open
Vansh0204 wants to merge 2 commits intoprocessing:dev-2.0from
Open
feat(typography): add PRETTY and BALANCE textWrap modes#8312Vansh0204 wants to merge 2 commits intoprocessing:dev-2.0from
Vansh0204 wants to merge 2 commits intoprocessing:dev-2.0from
Conversation
Author
Contributor
|
please update with dev-2.0 (and please be patient... we have many PRs to review) thank you |
…anced wrapping - Adds PRETTY and BALANCE constants to src/core/constants.js - Implements dynamic programming algorithm in _lineate for balanced line breaking - Minimizes raggedness by considering all possible line breaks - Includes manual test demonstrating PRETTY/BALANCE vs WORD wrap Addresses processing#7712
b9855f3 to
b2ca830
Compare
Author
|
@dhowe sir, I have updated to the latest dev-2.0 as requested. Ready for review when you have time! |
Contributor
|
@Vansh0204 do the manual tests that you added work for you? If so, please include screenshots here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PRETTYandBALANCEconstants tosrc/core/constants.js_lineate